Add API request & response structures for beatmap submission #31804
+310
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2025
peppy
reviewed
Feb 7, 2025
| // ReSharper disable once CollectionNeverUpdated.Global | ||
| public Dictionary<string, byte[]> FilesChanged { get; } = new Dictionary<string, byte[]>(); | ||
|
|
||
| // ReSharper disable once CollectionNeverUpdated.Global |
There was a problem hiding this comment.
I do wonder if we'll remember to remove these
There was a problem hiding this comment.
They're going away in the next PR in series, no worries.
peppy
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split out of the main pull due to a significant change to
IAPIProvider, in which rather than add a third string property next toAPIEndpointUrlandWebsiteRootUrlspecifically for submission, I decided to haveIAPIProviderexpose the fullEndpointConfigurationand rerouted the usage sites of the removed two properties to go through it, which added extra size and warranted a detour.Note that the development endpoint configuration does not yet specify an URL for a staging copy of the service. One exists, but is not currently ready to use (needs a few tweaks to make work).