User menu #50

claudiodekker · 2015-09-05T00:21:39Z

This should (hopefully) mark #45 as completed.

- Moved away forgot password and register links, which were both obtained via config() method, to a more approriate place for easier future management. Login Modal: - Completely removed and merged into the new user-dropdown object. (It was in a strange location to begin with) Master View/Layout: - Fixed a bug where the login modal was included even when you were logged in. - Instead of including the login model, we're now 'yielding' it instead. (It's now located in the new user-dropdown object) User-Dropdown Object: - New! - Contains logic for both logging in, and when we are actually logged in.

nekodex · 2015-09-05T01:45:16Z

Found an issue - if you repeatedly click on your avatar to show/hide the dialog too fast, the page progressively gets dimmer and dimmer.

claudiodekker · 2015-09-05T10:49:07Z

@nekodex Well spotted. Turns out that's an issue already in existence long before this feature was added, namely with the login modal. (Look at the currently live site, which doesn't include this commit)

To be fair, I don't think this issue is that important, as it doesn't block user-experience, but I'll still take a look at it, as it should also resolve the issue on the guest-side of things.

If possible, I'll see if I can create a separate bugtracker-issue for this & claim it, although I'm not sure if I've got the rights to do so.

nanaya · 2015-09-05T10:53:25Z

ctb (and other play mode) logo is available as font <i class="fa osu fa-ctb-o"></i>
country flags are in images/flags/
check this regarding css: CSS Major Overhaul #53
apparently having the modal button in front of overlay breaks the overlay ;_;
try using localization when possible
don't worry about prefixing, we have autoprefixer for that (there's also usage of flexbox which means you don't need to worry about ie < 10). And presto is dead

claudiodekker · 2015-09-05T10:57:21Z

@nanaya Alright, thanks. I'll get onto it in a bit.

Is there any quick(er) way for me to reach you regarding quick reviews/feedback on things, or should I just be a patient man? ;)

nanaya · 2015-09-05T10:59:25Z

you can reach me in slack. How fast I will respond is a bit of mystery though.

@nanaya

- Replaced gamemode icon (png) with the font version. - Now including country flags automatically (NOTE: I'm using the path "/images/flags/{{ Auth::user()->country_acronym }}.png") - Reworked the ENTIRE dropdown modal for both login and when logged in, to be based upon the BEM concept. - Now using localization As discussed with @nanaya on Slack, this entire has been reworked to be based upon the BEM concept: This also means that there is now a BEM folder, and a bem-index.less file, in which each BEM-block is being included by it's own .less file. This can be changed in the future, but for now I suppose this is okay. It's pretty much a playtest for now, doesn't really matter as it's easily moveable.

claudiodekker · 2015-09-06T02:36:31Z

Fixed most issues mentioned, and did some (on slack) discussed stuff..

Replaced gamemode icon (png) with the font version.
Now including country flags properly and directly from the existing flag icons.
Reworked the entire dropdown modal for both login and when logged in, to be based upon the BEM concept.
Now using localization

As discussed with @nanaya on Slack, this entire has been reworked to be based upon the BEM concept:

This also means that there is now a BEM folder, and a bem-index.less file, in which each BEM-block is being included by it's own .less file.

This can be changed relatively easy in the future, but for now I suppose this is okay.

…atic country flag for the time being

nanaya · 2015-09-09T13:32:38Z

sorry for late response,

there are merge conflicts
files should have end of lines
less files will have two spaces indentations from now on (following common style)

resources/assets/less/bem/badges.less

+		text-align: center;
+		display: block;
+
+		&--small {


resources/assets/less/bem/quick-info.less

+
+			.text-right {
+				font-weight: 600;
+				text-align: right;


Conflicts: resources/assets/less/login-modal.less

resources/lang/en/users.php

@@ -63,7 +60,8 @@
            ],
        ],
        'first_members' => 'here since the beginning',
-        'is_supporter' => 'osu!supporter',
+        'is_supporter' => 'osu!Supporter',


User menu

claudiodekker added 4 commits September 4, 2015 19:41

This should complete this issue.

22b9edc

Added missing top bar icons that were in the original PSD as well..

9d39728

Fixes a small formatting issue reported by StyleCI.

6866166

claudiodekker mentioned this pull request Sep 5, 2015

Minor: User and Login dropdown 'glitches' when toggled too quickly #54

Closed

claudiodekker mentioned this pull request Sep 5, 2015

Loggng in via in topic reply feature #51

Closed

nanaya changed the title ~~Issue 45~~ User menu Sep 5, 2015

claudiodekker added 3 commits September 6, 2015 04:57

Merge branch 'master' into Issue-45

10e6cc6

Apparently what I tried simply isn't implemented yet. Reverting to st…

2df340c

…atic country flag for the time being

Merge branch 'master' of https://github.com/ppy/osu-web into Issue-45

b20fb65

claudiodekker mentioned this pull request Sep 8, 2015

Missing some flags image #66

Closed

nanaya reviewed Sep 9, 2015
View reviewed changes

resources/assets/less/bem/badges.less

text-align: center;

display: block;

&--small {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

nanaya reviewed Sep 9, 2015
View reviewed changes

resources/assets/less/bem/quick-info.less

.text-right {

font-weight: 600;

text-align: right;

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

claudiodekker added 2 commits September 10, 2015 00:25

Fixed some issues..

9b1d3a6

Merge branch 'master' of https://github.com/ppy/osu-web into Issue-45

4996b35

Conflicts: resources/assets/less/login-modal.less

nanaya reviewed Sep 11, 2015
View reviewed changes

resources/lang/en/users.php

@@ -63,7 +60,8 @@

],

],

'first_members' => 'here since the beginning',

'is_supporter' => 'osu!supporter',

'is_supporter' => 'osu!Supporter',

This comment was marked as off-topic.

Sign in to view

claudiodekker added 2 commits September 14, 2015 17:02

Fixed all remaining issues as noted on the pull request..

04b6aef

Merge branch 'master' into Issue-45

83ec8af

peppy added a commit that referenced this pull request Sep 15, 2015

Merge pull request #50 from claudiodekker/Issue-45

a656c19

User menu

peppy merged commit a656c19 into ppy:master Sep 15, 2015

claudiodekker deleted the Issue-45 branch September 15, 2015 07:09

peppy mentioned this pull request Apr 14, 2016

Beatmap Info Page #466

Closed

arflyte mentioned this pull request Jun 1, 2016

Beatmap Details Page, Redesigned #559

Closed

Magnus-Cosmos mentioned this pull request Sep 20, 2019

Leaderboard unable to correctly sort large amount of scores with the same score #4991

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User menu #50

User menu #50

claudiodekker commented Sep 5, 2015

nekodex commented Sep 5, 2015

claudiodekker commented Sep 5, 2015

nanaya commented Sep 5, 2015

claudiodekker commented Sep 5, 2015

nanaya commented Sep 5, 2015

claudiodekker commented Sep 6, 2015

nanaya commented Sep 9, 2015

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

User menu #50

User menu #50

Conversation

claudiodekker commented Sep 5, 2015

nekodex commented Sep 5, 2015

claudiodekker commented Sep 5, 2015

nanaya commented Sep 5, 2015

claudiodekker commented Sep 5, 2015

nanaya commented Sep 5, 2015

claudiodekker commented Sep 6, 2015

nanaya commented Sep 9, 2015

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.