-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't commit files when creating a workspace #160
Comments
Hi!
|
Thank you @tengstrand but my use case if for creating a new project with polylith and I don't have a workspace.edn. I would argue that it's better to make this OPT-IN instead of OPT-OUT so people can turn it on if they want it. |
I agree with @ieugen -- I've always thought the default behavior (auto-committing) is a bad idea. I turn it off in |
Please have a look at the issue-160 branch and see if it behaves as expected (the gitbook doc has to be updated too). To get the current behaviour when creating a workspace, you now have to pass in The |
Only commit workspaces if passing in :commit to the 'create workspace' command. See issue #160
Describe the bug
A clear and concise description of what the bug is.
Ran
poly create
on an existing repository and poly created a commit automatically.That commit had a lot of extra files that would never reach git.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would like poly to allow me to commit instead of auto-comitting by default.
I believe the behaviour could be to OPT-IN for auto-commit via a cli parameter.
I also noticed that poly create will overwrite any files that happen to match what it creates.
You lose un-committed changes.
It happened with deps.edn and .gitignore.
Additional context
I did
git reset --soft
The text was updated successfully, but these errors were encountered: