Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Invitations] | ChangeProfileEmailInvite, RegistrationAccessInvite - Accept/Decline redirects fail #11151

Closed
1 task done
defstat opened this issue Mar 20, 2025 · 2 comments
Closed
1 task done

[Invitations] | ChangeProfileEmailInvite, RegistrationAccessInvite - Accept/Decline redirects fail #11151

defstat opened this issue Mar 20, 2025 · 2 comments
Assignees
@defstat
Milestone
3.5 Internal

Comments

@defstat
Copy link
Contributor

defstat commented Mar 20, 2025 •
edited
Loading

Valid Title

  • I have updated the title to accurately reflect the bug description

Description

In the cases of the ChangeProfileEmail and the RegistrationAccessInvite Invitations, the accept and decline redirects fail, even though the main action of accept or decline functions succesfully.

Steps to Reproduce

  1. Login with any user
  2. Navigate to User -> Edit Profile -> Contact
  3. Change the user's email address
  4. Go to the provided email mailbox
  5. Click the Accept link.
  6. A 404 http response will be displayed.

Expected Result

The correct redirect page should be displayed.

For ChangeProfileEmail: the user profile page -> user/profile -> tab: contact
For RegistrationAccessInvite: the registration success page user/activateUser

Actual Result

A 404 http response is displayed.

Environment Details

No response

Application Version

OJS, OMP, OPS stable 3.5.0, main branches

Logs

No response

Additional Information

No response

PRs

Branch stable-3_5_0
PKP-LIB: #11152
OJS: pkp/ojs#4776 TESTS ONLY

Branch main
PKP-LIB: #11153
OJS: pkp/ojs#4777 TESTS ONLY
@defstat defstat self-assigned this Mar 20, 2025
defstat added a commit to defstat/pkp-lib that referenced this issue Mar 20, 2025
@defstat
pkp#11151 Fix redirect function for ChangeProfileEmail and Registrati…
26132e3 
…onAccessInvite Invitations
defstat added a commit to defstat/pkp-lib that referenced this issue Mar 20, 2025
@defstat
pkp#11151 Fix redirect function for ChangeProfileEmail and Registrati…
4ca05ce 
…onAccessInvite Invitations
@defstat
Copy link
Contributor Author

defstat commented Mar 20, 2025

@asmecher here are some small but necessary fixes for the invitation functionality.

Could you review that?

@asmecher asmecher added this to the 3.5 Internal milestone Mar 20, 2025
asmecher pushed a commit that referenced this issue Mar 21, 2025
@defstat
#11151 Fix redirect function for ChangeProfileEmail and RegistrationA…
17d275e 
…ccessInvite Invitations (#11153)
asmecher pushed a commit that referenced this issue Mar 21, 2025
@defstat
#11151 Fix redirect function for ChangeProfileEmail and RegistrationA…
d5a75e2 
…ccessInvite Invitations (#11152)
@asmecher
Copy link
Member

Merged -- thanks, @defstat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@defstat defstat

Labels
None yet
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@asmecher @defstat