[Submission] | Discussion - Copyediting Stage, Discussion tags do not populate

[mbakioglu]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

Test: Take a new submission through the internal and external review stages
Status: Failed

In the Copyediting Stage, discussion titles and notifications do not populate the tags as expected.

Steps to Reproduce

1.Start a copyediting discussion as a Press Editor to request copyediting from the Copyeditor.
2.In the discussion panel, observe that the discussion title appears as:
"Submission 24 is ready to be copyedited for {$contextAcronym}."
3.The Copyeditor receives a notification stating:
"You have been asked to review copyedits for '{$file}'."

Expected Result

The discussion title should properly populate {$contextAcronym} and copyediting notification should properly populate {$file} tags.

Actual Result

The discussion title is not properly populating {$contextAcronym}, and the copyediting notification is not populating the {$file} tags.

Environment Details

No response

Application Version

OMP 3.5

Logs

No response

Additional Information

No response

[Tribunal33]

Might be related to #10962 . Similar missing variable reference.

[taslangraham]

Will take a look

[taslangraham]

Draft PRs

ojs main
ojs 3.5
ojs 3.4

omp main
omp 3.5
omp 3.4

pkp-lib main
pkp-lib 3.5
pkp-lib 3.4

[taslangraham]

Ready for review @asmecher @Vitaliy-1

Changes

• Rename contextAcronym email variable to app specific variable name (e.g journalAcronym for OJS) during installation.
• Add migration script to update existing contextAcronym email variable to app specific variable in database.
• [OMP] remove app level locale for notification.type.copyeditorRequest which had invalid {$file} variable.
  • Locales already exists within pkp-lib
• First 2 bullet points also fixes #10962

PRs

ojs main
ojs 3.5
ojs 3.4

omp main
omp 3.5
omp 3.4

pkp-lib main
pkp-lib 3.5
pkp-lib 3.4