Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider role masthead options in the old UserForm #11087

Open
bozana opened this issue Mar 13, 2025 · 5 comments
Open

Consider role masthead options in the old UserForm #11087

bozana opened this issue Mar 13, 2025 · 5 comments
Assignees
@bozana
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone
3.5 Internal

Comments

@bozana
Copy link
Collaborator

bozana commented Mar 13, 2025 •
edited
Loading

Provide possibility to define if the user will be displayed on the masthead for a role in the old UserForm, that currently can be accessed by admin.
According to the design/UX all user roles should be pre-selected per default, except reviewer roles.

PRs:
stable-3_5_0:
@bozana bozana added this to the 3.5 Internal milestone Mar 13, 2025
@bozana bozana self-assigned this Mar 13, 2025
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Mar 13, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 19, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
7c376ce
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 19, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
8bf84c3
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 19, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
17e83e7
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 19, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
8b86a1d
@bozana bozana mentioned this issue Mar 19, 2025
Open
@bozana
Copy link
Collaborator Author

bozana commented Mar 19, 2025

Hi @asmecher, would you maybe be able to take a look at the PR above?
Thanks a lot!

@asmecher
Copy link
Member

Added a review to the stable-3_5_0 PR. Looks like the link to the main PR got lost in the head comment?

@bozana
Copy link
Collaborator Author

bozana commented Mar 19, 2025

Hi @asmecher, thanks, I will consider the comments. I then thought to cherry-pick it all to main, when finished, that's why the main PR is missing...

bozana added a commit to bozana/pkp-lib that referenced this issue Mar 20, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
aa1b581
bozana added a commit to bozana/ojs that referenced this issue Mar 20, 2025
@bozana
pkp/pkp-lib#11087 submodule update ##bozana/11087-3_5_0##
921a060
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 20, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
00911a2
bozana added a commit to bozana/ojs that referenced this issue Mar 20, 2025
@bozana
pkp/pkp-lib#11087 submodule update ##bozana/11087-3_5_0##
3d6f5da
@bozana bozana mentioned this issue Mar 20, 2025
Open
@bozana
Copy link
Collaborator Author

bozana commented Mar 20, 2025

Hi @asmecher, oh good comments -- I realized also other parts of UserForm should be improved.
Could you please take another look?
Thanks a lot!

@asmecher
Copy link
Member

@bozana, I made another few individual comments, thanks! This might have to wait post-3.5.0rc2.

bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
8970716
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
88aecc8
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 remove UserUserGroupMastheadStatus, consider UserMastheadSt…
132db25 
…atus
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 remove UserUserGroupMastheadStatus, consider UserMastheadSt…
cc4fb24 
…atus
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 remove UserUserGroupMastheadStatus, consider UserMastheadSt…
5a4d688 
…atus
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 remove UserUserGroupMastheadStatus, consider UserMastheadSt…
c8b6763 
…atus
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 consider masthead options in the old UserForm
a4ddf7a
bozana added a commit to bozana/pkp-lib that referenced this issue Mar 21, 2025
@bozana
pkp#11087 remove UserUserGroupMastheadStatus, consider UserMastheadSt…
c049ff8 
…atus
bozana added a commit to bozana/ojs that referenced this issue Mar 21, 2025
@bozana
pkp/pkp-lib#11087 submodule update ##bozana/11087-3_5_0##
a845d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bozana bozana

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@asmecher @bozana