Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntuサポートを終了してMySQLバージョン整理する #71

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

yuki777
Copy link
Collaborator

@yuki777 yuki777 commented Feb 20, 2025

  • Ubuntuサポートを終了し、macOS専用になりました
  • MySQLのアーキテクチャは下記の通りです
    • x86_64
      • 5.7.31 x86_64
      • 8.0.23 x86_64
      • 8.0.30 x86_64
Screenshot 2025-02-20 at 7 57 57
  • arm64
    • 8.0.41 arm64
    • 8.4.4 arm64
    • 9.2.0 arm64
Screenshot 2025-02-20 at 7 58 16

Summary by CodeRabbit

  • Chores
    • テストの実行環境がmacOSのみとなり、不要な設定が削除されました。これにより、テストプロセスのシンプルさと効率が向上しました。
  • New Features
    • MySQLのサポートバージョンが更新されました。新たに8.0.41、8.4.4、9.2.0が追加され、8.0.23が削除されました。
    • 新しいテストスクリプト「mysql-9.2.0.sh」が追加され、MySQLデータベースの包括的なテストフレームワークが提供されます。

Verified

This commit was signed with the committer’s verified signature.
brerx Thomas Müller

Verified

This commit was signed with the committer’s verified signature.
brerx Thomas Müller
Copy link

coderabbitai bot commented Feb 20, 2025

Warning

Rate limit exceeded

@yuki777 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a5eb181 and d417409.

📒 Files selected for processing (1)
  • README.md (2 hunks)

"""

Walkthrough

このプルリクエストは、GitHub Actions のテストジョブのワークフローファイル(.github/workflows/test.yml)の設定を更新しています。以前は macos-latestubuntu-latest の両方が指定されていましたが、更新後は macos-latest のみが使用されます。また、MySQLスクリプトのリストが更新され、2つの旧バージョンが削除され、新しいバージョンが追加されています。さらに、ubuntu-latest 用のメモリオーバーコミットを有効化するための行が削除されました。README.md ではサポートされるMySQLのバージョンが更新され、新しいスクリプトが追加されています。

Changes

ファイル 変更内容
.github/workflows/test.yml OSマトリックスから ubuntu-latest を削除し、macos-latest のみ設定。
MySQLスクリプトのリストを更新し、mysql-5.7.31.shmysql-8.0.30.sh を削除、mysql-8.0.41.shmysql-8.4.4.sh を追加。
ubuntu-latest 用のメモリオーバーコミット関連の行と警告コメントを削除。
README.md サポートされるMySQLバージョンを更新。
旧バージョン 8.0.23 を削除し、8.0.418.4.49.2.0 を追加。
lib/functions.sh getRandomPort 関数のエラーメッセージを /dev/null にリダイレクトするように変更。
tests/mysql-8.0.41.sh MySQLバージョンを 5.7.31 から 8.0.41 に更新。
tests/mysql-8.4.4.sh MySQLバージョンを 8.0.30 から 8.4.4 に更新。
tests/mysql-9.2.0.sh 新しいスクリプト mysql-9.2.0.sh を追加。

Sequence Diagram(s)

Loading
sequenceDiagram
    participant CI as GitHub Actions Runner
    participant Job as Test Job
    CI->>Job: ワークフロー開始 (macos-latest)
    Job->>Job: リポジトリのチェックアウト
    Job->>Job: テスト実行
    Job-->>CI: テスト結果の報告

Poem

小さな耳で跳ねる僕、
コードの森を駆け抜ける。
Ubuntuの影はもう去り、
Macの光だけが柔らかく照らす。
変更の風に乗って、
新たな道を元気に進むよ!
🐰✨
"""


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/test.yml (1)

25-33: テスト実行ステップの重複について検討してください
現在、2 つの「Run test」ステップが存在しますが、最初のステップは単に cd tests を実行するのみで、その後の処理がありません。2 番目のステップではディレクトリ移動後にスクリプトが実行されています。意図的な設計であるか、不要な冗長性であるかを確認し、不要であれば統合または削除を検討してください。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5aad3b and 467e0b7.

📒 Files selected for processing (1)
  • .github/workflows/test.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/test.yml (1)

10-10: プラットフォーム設定の変更を確認してください
マトリックスで指定された OS が macos-latest のみとなっています。以前は ubuntu-latest も含まれていたため、この変更が意図通りであり、必要なテストカバレッジを損なわないことを再確認してください。

Verified

This commit was signed with the committer’s verified signature.
brerx Thomas Müller
@yuki777 yuki777 changed the title Empty commit MySQLバージョン整理する Feb 20, 2025
@yuki777 yuki777 changed the title MySQLバージョン整理する Ubuntuサポートを終了してMySQLバージョン整理する Feb 20, 2025
@yuki777 yuki777 merged commit 0dd7cca into main Feb 20, 2025
10 checks passed
@yuki777 yuki777 deleted the mysql-versions branch February 20, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant