Skip to content

Commit

Permalink
refactor: remove getHeaderNames() polyfill and refactor `clearHeade…
Browse files Browse the repository at this point in the history
…rs()`

`ServerResponse.getHeaderNames()` is available since Node v7.7.0
  • Loading branch information
Phillip9587 committed Feb 18, 2025
1 parent 44abc4d commit ee6f809
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 18 deletions.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ unreleased
* deps:
* `fresh@^2.0.0`
* removed `destroy`
* remove `getHeaderNames()` polyfill and refactor `clearHeaders()`

1.1.0 / 2024-09-10
==================
Expand Down
20 changes: 2 additions & 18 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -775,10 +775,8 @@ SendStream.prototype.setHeader = function setHeader (path, stat) {
*/

function clearHeaders (res) {
var headers = getHeaderNames(res)

for (var i = 0; i < headers.length; i++) {
res.removeHeader(headers[i])
for (const header of res.getHeaderNames()) {
res.removeHeader(header)
}
}

Expand Down Expand Up @@ -886,20 +884,6 @@ function decode (path) {
}
}

/**
* Get the header names on a response.
*
* @param {object} res
* @returns {array[string]}
* @private
*/

function getHeaderNames (res) {
return typeof res.getHeaderNames !== 'function'
? Object.keys(res._headers || {})
: res.getHeaderNames()
}

/**
* Determine if emitter has listeners of a given type.
*
Expand Down

0 comments on commit ee6f809

Please sign in to comment.