Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for watch providers #241

Merged
merged 13 commits into from
Sep 10, 2021
Merged

Conversation

neildaniels
Copy link
Contributor

@neildaniels neildaniels commented May 27, 2021

This is an attempt to resolve #240 by adding support for Watch Providers.

Feedback, patches, or alternative PRs more than welcome.

  • Movie > Watch Providers
  • TV Show > Watch Providers
  • Movie Discover > Filter by Watch Providers
  • TV Show Discover > Filter by Watch Providers
  • Watch Providers > Available Regions
  • Watch Providers > Movie Providers
  • Watch Providers > TV Show Providers

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #241 (322a2a0) into 4.0 (e800d43) will increase coverage by 0.38%.
The diff coverage is 98.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.0     #241      +/-   ##
============================================
+ Coverage     84.06%   84.45%   +0.38%     
- Complexity     2107     2166      +59     
============================================
  Files           194      196       +2     
  Lines          5303     5454     +151     
============================================
+ Hits           4458     4606     +148     
- Misses          845      848       +3     
Impacted Files Coverage Δ
lib/Tmdb/Model/Query/Discover/DiscoverTvQuery.php 95.83% <86.95%> (-4.17%) ⬇️
lib/Tmdb/Api/Movies.php 95.65% <100.00%> (+0.19%) ⬆️
lib/Tmdb/Api/Tv.php 100.00% <100.00%> (ø)
lib/Tmdb/Factory/MovieFactory.php 89.86% <100.00%> (+1.31%) ⬆️
lib/Tmdb/Factory/TvFactory.php 78.88% <100.00%> (+2.20%) ⬆️
lib/Tmdb/Model/Movie.php 99.12% <100.00%> (+0.02%) ⬆️
.../Tmdb/Model/Query/Discover/DiscoverMoviesQuery.php 65.34% <100.00%> (+3.39%) ⬆️
lib/Tmdb/Model/Tv.php 84.05% <100.00%> (+0.42%) ⬆️
lib/Tmdb/Model/Watch/Provider.php 100.00% <100.00%> (ø)
lib/Tmdb/Model/Watch/Providers.php 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e800d43...322a2a0. Read the comment docs.

@neildaniels neildaniels force-pushed the watch-providers branch 2 times, most recently from 84e0ef9 to a40d7af Compare August 27, 2021 23:12
@neildaniels neildaniels marked this pull request as ready for review August 27, 2021 23:40
@neildaniels
Copy link
Contributor Author

This PR still does not include support for fetching the list of available regions, list of movie providers, and list of tv providers.

However, I have added tests for the behavior it does support. I think this PR is still worth merging in, as I'm unsure when I'd have time to add support for the remaining parts.

@neildaniels neildaniels requested a review from wtfzdotnet August 27, 2021 23:44
@wtfzdotnet
Copy link
Member

This PR still does not include support for fetching the list of available regions, list of movie providers, and list of tv providers.

However, I have added tests for the behavior it does support. I think this PR is still worth merging in, as I'm unsure when I'd have time to add support for the remaining parts.

Checked it a few times without really getting the heads-up you wanted to merge it without all tasks completed; going to check it now :-).

@wtfzdotnet
Copy link
Member

Thanks for the addition @neildaniels :-), cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Watch Providers Support
3 participants