ISSUE-1317: Fix model --force creation bugs #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeMySlaveDarlin
force-pushed
the
f/issue-1317-fix-force-creation-bugs
branch
from
a295d7f to
5edf93e
Compare
Codecov Report
@@ Coverage Diff @@
## 4.0.x #1498 +/- ##
========================================
+ Coverage 3.15% 3.16% +0.01%
========================================
Files 111 111
Lines 5106 5079 -27
========================================
Hits 161 161
+ Misses 4945 4918 -27 |
BeMySlaveDarlin
force-pushed
the
f/issue-1317-fix-force-creation-bugs
branch
2 times, most recently
from
77a3484 to
812c6de
Compare
This was
linked to
issues
Mar 22, 2021
BeMySlaveDarlin
force-pushed
the
f/issue-1317-fix-force-creation-bugs
branch
from
812c6de to
449e684
Compare
Jeckerson
reviewed
Mar 22, 2021
Jeckerson
requested changes
Mar 22, 2021
BeMySlaveDarlin
force-pushed
the
f/issue-1317-fix-force-creation-bugs
branch
from
449e684 to
e249db0
Compare
Jeckerson
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Fixed constants dropping in models when recreating with
--forceoption: constants with access modifiers (public, protected, private) were ignored by preg_match pattern.Fixed attributes duplication bug when recreating with
--forceoption if no--camelizeoption declared and property is snake_cased.Fixed column mapping on creation from table with PascalCase fields.
Thanks