Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1297: Removed getSource() method due to final implementation #1497

Conversation

BeMySlaveDarlin
Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin commented Mar 21, 2021

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:
Removed getSource() method generation.
It became final in phalcon/cphalcon#13950

Thanks

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #1497 (f1ae3aa) into 4.0.x (94d96c9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##           4.0.x   #1497   +/-   ##
=====================================
  Coverage   3.15%   3.15%           
=====================================
  Files        111     111           
  Lines       5109    5106    -3     
=====================================
  Hits         161     161           
+ Misses      4948    4945    -3     

@BeMySlaveDarlin BeMySlaveDarlin force-pushed the fix/issue-1297-removed-get-source-method branch from afb2018 to f1ae3aa Compare March 21, 2021 23:31
@Jeckerson Jeckerson merged commit e75d332 into phalcon:4.0.x Mar 22, 2021
@Jeckerson Jeckerson added this to the 4.0.x milestone Mar 22, 2021
@BeMySlaveDarlin BeMySlaveDarlin deleted the fix/issue-1297-removed-get-source-method branch May 4, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants