Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1471 - Fix Di instance order #1472

Merged
merged 4 commits into from
Oct 9, 2020
Merged

#1471 - Fix Di instance order #1472

merged 4 commits into from
Oct 9, 2020

Conversation

pgalocha
Copy link
Contributor

@pgalocha pgalocha commented Oct 9, 2020

Small description of change:

Changed Di instance order in Boostrap File. Was being instanciated after the App class, when it needs to be in first place to be utilised in App object.

@Jeckerson Jeckerson linked an issue Oct 9, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #1472 into 4.0.x will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             4.0.x   #1472      +/-   ##
==========================================
- Coverage     3.55%   3.44%   -0.12%     
==========================================
  Files          111     111              
  Lines         4757    5114     +357     
==========================================
+ Hits           169     176       +7     
- Misses        4588    4938     +350     

@Jeckerson Jeckerson merged commit afb2a9b into phalcon:4.0.x Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webtools fatal error in Bootstrap file
2 participants