Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test scaffold generated files #1454

Merged
merged 23 commits into from
Apr 19, 2020
Merged

Conversation

jenovateurs
Copy link
Contributor

Hello team!

I added some tests about Scaffold.
The tests check the file generated by Scaffold with Volt and Phtml.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks for the review

@jenovateurs jenovateurs self-assigned this Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #1454 into 4.0.x will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           4.0.x   #1454      +/-   ##
========================================
+ Coverage   3.42%   3.44%   +0.01%     
========================================
  Files        111     111              
  Lines       5114    5114              
========================================
+ Hits         175     176       +1     
+ Misses      4939    4938       -1     

@jenovateurs
Copy link
Contributor Author

About Codacy, I don't know how to handle it.
It's about Codeception use.

@jenovateurs jenovateurs merged commit d808549 into phalcon:4.0.x Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants