Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error Psalm - Calling empty on a boolean value is almost certainly unintended #1449

Merged
merged 5 commits into from
Apr 11, 2020

Conversation

jenovateurs
Copy link
Contributor

Hello team!

I fixed some errors that Psalm found.
And I resolve the problem with empty - Calling empty on a boolean value is almost certainly unintended

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #1449 into 4.0.x will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           4.0.x   #1449      +/-   ##
========================================
+ Coverage   3.30%   3.42%   +0.11%     
========================================
  Files        111     111              
  Lines       5108    5114       +6     
========================================
+ Hits         169     175       +6     
  Misses      4939    4939              

@jenovateurs
Copy link
Contributor Author

I don't know why Github CI triggered errors ? In my fork project, there is no issue : https://github.com/les-enovateurs/phalcon-devtools/actions/runs/75916762

@jenovateurs jenovateurs requested a review from Jeckerson April 11, 2020 13:03
This was referenced Apr 11, 2020
@Jeckerson Jeckerson merged commit 9845d60 into phalcon:4.0.x Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants