Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1412 - Fix root uri #1413

Merged
merged 3 commits into from
Jan 4, 2020
Merged

#1412 - Fix root uri #1413

merged 3 commits into from
Jan 4, 2020

Conversation

Jeckerson
Copy link
Member

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Thanks

@Jeckerson Jeckerson added this to the 4.0.x milestone Jan 4, 2020
@Jeckerson Jeckerson self-assigned this Jan 4, 2020
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #1413 into 4.0.x will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             4.0.x   #1413   +/-   ##
=======================================
  Coverage     3.55%   3.55%           
  Complexity    1099    1099           
=======================================
  Files          111     111           
  Lines         4758    4758           
=======================================
  Hits           169     169           
  Misses        4589    4589
Impacted Files Coverage Δ Complexity Δ
src/Providers/RouterProvider.php 0% <0%> (ø) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688a6c9...adc0857. Read the comment docs.

@Jeckerson Jeckerson merged commit caa898c into 4.0.x Jan 4, 2020
@Jeckerson Jeckerson deleted the fix/#1412-root-uri branch January 4, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants