Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile for generate phar file #1388

Merged
merged 2 commits into from
Dec 7, 2019
Merged

Add Dockerfile for generate phar file #1388

merged 2 commits into from
Dec 7, 2019

Conversation

MilesChou
Copy link
Contributor

Hello!

  • Type: new feature
  • Link to issue: No issue

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Cannot write test for this PR.

Small description of change:

Add Dockerfile for generate phar file, see MilesChou/docker-phalcon#41 for more information.

Thanks

@Jeckerson
Copy link
Member

Jeckerson commented Dec 6, 2019 •
edited
Loading

Could you move Dockerfile inside build folder?
And rename it BuildPharDockerfile.
Also, some note in readme.md

@Jeckerson Jeckerson added this to the 3.4.x milestone Dec 6, 2019
@Jeckerson Jeckerson merged commit 67b9a76 into phalcon:3.4.x Dec 7, 2019
@Jeckerson Jeckerson mentioned this pull request Dec 7, 2019
Merged
@MilesChou MilesChou deleted the add-dockerfile branch December 8, 2019 07:29
@MilesChou MilesChou mentioned this pull request Dec 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

@ruudboon ruudboon ruudboon approved these changes

Assignees
No one assigned
Labels
Installation
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@MilesChou @Jeckerson @ruudboon