Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BuildPharDockerfile in 4.0.x branch #1421

Closed
Jeckerson opened this issue Jan 19, 2020 · 2 comments
Closed

Remove BuildPharDockerfile in 4.0.x branch #1421

Jeckerson opened this issue Jan 19, 2020 · 2 comments
Assignees
@Jeckerson
Milestone
4.0.x

Comments

@Jeckerson
Copy link
Member

Due native .phar building each release, current files are useless for Phalcon DevTools since version 4.

Files to remove:

  • build/BuildPharDockerfile
  • Makefile

/cc @MilesChou please tell if you still need this files for v4.
@Jeckerson Jeckerson added this to the 4.0.x milestone Jan 19, 2020
@MilesChou
Copy link
Contributor

Got it, I will download .phar file from GitHub Releases

@Jeckerson Jeckerson self-assigned this Jan 20, 2020
Jeckerson added a commit that referenced this issue Jan 20, 2020
@Jeckerson
#1421 - Remove build/BuildPharDockerfile and Makefile
33eb1f6
@Jeckerson Jeckerson mentioned this issue Jan 20, 2020
Merged
3 tasks
Jeckerson added a commit that referenced this issue Jan 20, 2020
@Jeckerson
Merge pull request #1422 from phalcon/feature/#1421-remove-dockerfile…
5807cbb 
…-phar

#1421 - Remove build/BuildPharDockerfile and Makefile
@Jeckerson
Copy link
Member Author

Done in #1422

@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
None yet
Projects
Phalcon v5
Archived in project
Milestone
4.0.x
Development

No branches or pull requests
2 participants
@MilesChou @Jeckerson