Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold requires sessionBag #1402

Closed
ruudboon opened this issue Dec 16, 2019 · 2 comments
Closed

Scaffold requires sessionBag #1402

ruudboon opened this issue Dec 16, 2019 · 2 comments
Assignees
@Jeckerson
Labels
Bug - Low
Milestone
4.0.0

Comments

@ruudboon
Copy link
Member

When using scaffold the controller contains reference to persistent
Persistent requires sessionBag to be available in the di.
We got 2 solutions.

  1. Add sessionBag by default in al the services.
  2. Rewrite scaffold
@ruudboon ruudboon added this to the 4.0.0 milestone Dec 16, 2019
@Jeckerson
Copy link
Member

I suggest to remove it, as I did in other projects like Vokuro and Invo, during update to v4.

@Jeckerson Jeckerson self-assigned this Dec 16, 2019
Jeckerson added a commit that referenced this issue Dec 19, 2019
@Jeckerson
#1402 - Refactor in Scaffold views
d55c0e4
Jeckerson added a commit that referenced this issue Dec 19, 2019
@Jeckerson
#1402 - Remove usage of persistent property
a2cc60e
@Jeckerson Jeckerson mentioned this issue Dec 19, 2019
Merged
3 tasks
Jeckerson added a commit that referenced this issue Dec 20, 2019
@Jeckerson
Merge pull request #1404 from phalcon/fix/#1402-remove-requirements-s…
30994f0 
…ession-bag

#1402 - Remove requirements of SessionBag
@Jeckerson
Copy link
Member

Fixed.

@Jeckerson Jeckerson mentioned this issue Dec 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
Bug - Low
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@Jeckerson @ruudboon