Faster phalcon_array_merge_recursive_n() #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Box hash key into an undestructable zval so that a call to phalcon_memory_observe() can be avoided
phalcon
pushed a commit
that referenced
this pull request
Jul 12, 2013
Faster phalcon_array_merge_recursive_n()
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
array_merge_recursive_n()because it was a duplicate ofphalcon_array_merge_recursive_n()phalcon_get_current_key_w()that returns azvalthat boxes the current key; this zval does not have to be destroyed, therefore PHALCON_MM_GROW()/PHALCON_MM_RESTORE() can be sometimes avoided;TSRMLSfromphalcon_array_merge_recursive_n()thanks tophalcon_get_current_key_w()