Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16608 compiler compilesource #16609

Merged
merged 6 commits into from
Jun 7, 2024
Merged

T16608 compiler compilesource #16609

merged 6 commits into from
Jun 7, 2024

Conversation

niden
Copy link
Member

@niden niden commented Jun 7, 2024

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Mvc\View\Engine\Volt\Compiler::compileSource to also return array

Thanks

@niden niden requested a review from Jeckerson June 7, 2024 18:06
@niden niden self-assigned this Jun 7, 2024
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jun 7, 2024
@niden niden merged commit 8827949 into phalcon:5.0.x Jun 7, 2024
50 checks passed
@niden niden deleted the T16608-compiler-compilesource branch June 7, 2024 23:07
@niden niden mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson