-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed infinite save loop #16395 #16399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafc84f
to
bc23560
Compare
niden
approved these changes
Aug 11, 2023
Jeckerson
reviewed
Aug 11, 2023
Jeckerson
reviewed
Aug 11, 2023
Jeckerson
reviewed
Aug 11, 2023
Jeckerson
reviewed
Aug 11, 2023
Jeckerson
reviewed
Aug 11, 2023
a4fccd4
to
a002502
Compare
@rudiservo please rebase this branch. |
@Jeckerson I think it's ok now. |
c8515e0
to
aeb5ed9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Added an array with already visited objects by the save or the SaveRelated chain functions in order to avoid save loops
Performance Tests where made between SplObjectStorage and the PHP Array.
There are two function to get a unique ID from a Php object, spl_object_hash and spl_object_id.
Using spl_object_hash, SplObjectStorage is faster and uses less memory, spl_object_storage is the function SplObjectStorage uses.
Using the spl_object_id the php Array is faster and uses less memory by a small margin, however since Zephir cannot pass by reference, SplObjectStorage is the better option.
Thanks