Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagFactory, Profiler, Cil container fixes #16234

Merged
merged 9 commits into from
Nov 30, 2022
Merged

TagFactory, Profiler, Cil container fixes #16234

merged 9 commits into from
Nov 30, 2022

Conversation

niden
Copy link
Member

@niden niden commented Nov 30, 2022 •
edited
Loading

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Fixing Phalcon\Html\TagFactory docblock for autocompletion (0129658)
Fixed Phalcon\Db\Profiler by correctly calculating the seconds (reapplied changes) #15822
Added Phalcon\Html\TagFactory to the Phalcon\Di\FactoryDefault\Cli #16233

Thanks

@niden niden self-assigned this Nov 30, 2022
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Nov 30, 2022
@niden niden requested a review from Jeckerson November 30, 2022 16:30
@niden niden merged commit 67b5fa1 into phalcon:5.0.x Nov 30, 2022
This was referenced Nov 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson