Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T14936 json decode #15025

Merged
merged 3 commits into from
May 6, 2020
Merged

T14936 json decode #15025

merged 3 commits into from
May 6, 2020

Conversation

niden
Copy link
Member

@niden niden commented May 6, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\Http\Request::getJsonRawBody to use json_decode instead of Phalcon\Json::decode

Thanks

@niden niden linked an issue May 6, 2020 that may be closed by this pull request
[BUG]: Different behavior json_decode and \Phalcon\Helper\Json::decode() #14936
Closed
@sergeyklay sergeyklay added 4.0.6 bug A bug report labels May 6, 2020
@sergeyklay sergeyklay merged commit eee67b3 into phalcon:4.0.x May 6, 2020
@niden niden deleted the T14936-json-decode branch May 6, 2020 19:52
sergeyklay added a commit that referenced this pull request May 6, 2020
@sergeyklay
Regenerate C code
7425e0e 
See: #15025
niden pushed a commit that referenced this pull request May 6, 2020
@sergeyklay @niden
Regenerate C code
87a248e 
See: #15025
niden pushed a commit that referenced this pull request May 16, 2020
@sergeyklay @niden
Regenerate C code
e3539fc 
See: #15025
niden pushed a commit that referenced this pull request May 31, 2020
@sergeyklay @niden
Regenerate C code
796a3b3 
See: #15025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
bug A bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Different behavior json_decode and \Phalcon\Helper\Json::decode()
2 participants
@niden @sergeyklay