T14783 integration suite rework #14803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudboon
requested changes
Feb 2, 2020
|
Few lines of feedback. But in general great work @niden |
|
@ruudboon I will check those tonight maybe tomorrow. I have a bit more refactoring to do with the services of the DiTrait and this would be done |
ruudboon
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Created
databasesuite to be run with--env mysqlparameter against the target RDBMSKept integration tests where they are unless they access the database
Moved potential db tests in a
tocheckfolder so that we can slowly work and enable them.Suite runs
sqliteandmysqltests.pgsqlsuite needs work (tables are not created? not sure for now)Thanks