Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use phalcon_fetch_static_property_ce and phalcon_update_static_property_ce #1293

Merged
merged 3 commits into from Sep 26, 2013
Merged

Use phalcon_fetch_static_property_ce and phalcon_update_static_property_ce #1293

merged 3 commits into from Sep 26, 2013

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2013

Pros:

  • phalcon_fetch_static_property_ce() does not need PHALCON_OBS_VAR()
  • phalcon_fetch_static_property_ce() and phalcon_update_static_property_ce() use zend_class_entry — this saves hash table lookup.

Plus:

  • use interned strings in \Phalcon\Tag

phalcon pushed a commit that referenced this pull request Sep 26, 2013
Merge pull request #1293 from sjinks/static-properties
aa8090b 
Use phalcon_fetch_static_property_ce and phalcon_update_static_property_ce
@phalcon phalcon merged commit aa8090b into phalcon:1.3.0 Sep 26, 2013
@ghost ghost deleted the static-properties branch September 26, 2013 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phalcon @sjinks