Resize transformer fix #27

Fiddl3 · 2014-12-05T15:05:35Z

Many changes, please look at commit comments.
I tried to commit small code changes related to one issue at time.

ResizeTransformer should now work more smoothly, because layout is redrawn only once in one pass of Drag Listener.

I removed some unnecessary methods an simplified Transformers code...

Gradle wrapper update (2.2.1) Build Gradle plugin update (1.0.0-rc3) Build Tools and target SDK updated to lastest YoutubePlayerApi no longer exist on gradle (not uses jar library)

Fixed SecondView positionig in Maximized State Fixed Preview in Android Studio (DraggablePanel should be treated as RelativeLayout) ex: layout\activity_tv_shows_sample.xml Fixed horizontal drag issues

…thods

Every methods/variables related to last position. This was used in old onLayout() implementation

float to int everywhere except scaleFactor

Changed implementatnio of position calculation Changed implemenation of getMinWidth() method Fixed sample app (I forgot about that in prev commit)

Removed unnecesary metods & variables Methods where size is calculated are merged - now in one pas of dragEvent dragView is redrawed only once, not twice

pedrovgs · 2014-12-05T15:10:43Z

Nice PR, can you update this branch with pedrovgs:develop?

Fiddl3 · 2014-12-05T15:29:57Z

Travis say Could not find com.android.support:support-v4:21.0.2. xD
There is no support library on maven central (I think is in local repo, when you install android google support libs via SDK Manager)

pedrovgs · 2014-12-05T15:31:48Z

xD Revert your build.gradle changes to use an older version. I'll update that dependencies later.

pedrovgs · 2014-12-05T16:55:04Z

draggablepanel/src/main/java/com/github/pedrovgs/DraggableViewCallback.java

-  private static final float X_MIN_VELOCITY = 1300;
-  private static final float Y_MIN_VELOCITY = 1300;
+  private static final float X_MIN_VELOCITY = 1500;
+  private static final float Y_MIN_VELOCITY = 1000;


Why have you changed X_MIN_VELOCITY, Y_MIN_VELOCITY and MINIMUN_DX_FOR_HORIZONTAL_DRAG?

Fiddl3 · 2014-12-05T17:02:09Z

MINIMUN_DX_FOR_HORIZONTAL_DRAG typo in MINIMU``N word

...MIN_VELOCITY - I've tested various values and this to works ok for me, Y_MIN_VELOCITY was too high for landscape mode.

pedrovgs · 2014-12-05T17:03:39Z

Can you restore the value of MINIMUN_DX_FOR_HORIZONTAL_DRAG to 5?

Fiddl3 · 2014-12-05T17:18:01Z

hmmmm.... I'm thinking MINIMUM_DX & MINIMUM_DY should be density dependent...

pedrovgs · 2014-12-05T17:22:00Z

Yes, should be density dependent. We can do that in other PR.

pedrovgs · 2014-12-05T17:32:50Z

There is something wrong with tv shows sample, ScaleTransformer and this branch :S. Here you have a video https://drive.google.com/file/d/0B9xkpTnF9BXjbDZQcU4tR1ZfblE/view?usp=sharing Can you take a look. This is the last fix needed to merge this PR :)

Fiddl3 · 2014-12-05T17:35:51Z

Whats wrong there? I don't know where I should look

Fiddl3 · 2014-12-05T17:36:50Z

aaa I see, second view content is missing, I'll take look at this

pedrovgs · 2014-12-05T17:56:42Z

Review also how you measure your max bottom position. I've changed your <item name="y_scale_factor" format="float" type="dimen">2</item> to <item name="y_scale_factor" format="float" type="dimen">2.3</item> and is working as you can see in this video: https://drive.google.com/file/d/0B9xkpTnF9BXjZndQOE9vSDNCa0E/view?usp=sharing

This should be at end

especially for Travis

This reverts commit d3f77f7.

This reverts commit 27e35d7.

Fiddl3 · 2014-12-05T21:03:46Z

travis doesn't like me & lastest google support library....
Travis downloads and installs support library, but then it doesn't see it... https://travis-ci.org/pedrovgs/DraggablePanel/builds/43138658#L935

Resize transformer fix.

pedrovgs · 2014-12-06T13:08:03Z

Thanks @Fiddl3 for this pull request!!!! I'm going to update project readme with a contributors section and you will be there :) What's your name and last name?

Fiddl3 · 2014-12-06T13:20:29Z

No problem :)
I'll continue working on lanscape support when I'll have time
I'm Rafał Pluta

pedrovgs · 2014-12-06T13:45:17Z

If you are using this library in any project, please send me an email with
the project name and link to update README.md file with that information.

2014-12-06 14:20 GMT+01:00 Fiddl3 [email protected]:

No problem :)
I'll continue working on lanscape support when I'll have time
I'm Rafał Pluta

—
Reply to this email directly or view it on GitHub
#27 (comment)
.

Fiddl3 · 2014-12-06T14:39:02Z

This project is still in dev stage, I still have problems with rtmp stream playback...

pedrovgs · 2014-12-06T14:40:34Z

Ok, let me know once be published! Good luck ;)
On Dec 6, 2014 3:39 PM, "Fiddl3" [email protected] wrote:

This project is still in dev stage, I still have problems with rtmp stream
playback...

—
Reply to this email directly or view it on GitHub
#27 (comment)
.

Fiddl3 · 2014-12-06T14:41:25Z

I will, thanks.

Fiddl3 added 7 commits December 5, 2014 00:05

Gradle update

03d6373

Gradle wrapper update (2.2.1) Build Gradle plugin update (1.0.0-rc3) Build Tools and target SDK updated to lastest YoutubePlayerApi no longer exist on gradle (not uses jar library)

Fix for issue pedrovgs#12 and pedrovgs#20

ba33447

Fixed SecondView positionig in Maximized State Fixed Preview in Android Studio (DraggablePanel should be treated as RelativeLayout) ex: layout\activity_tv_shows_sample.xml Fixed horizontal drag issues

Changes in ScaleTransformer isNextToLeftBound & isNextToRightBound me…

94672d4

…thods

Removed unnecessary variables & methods

2403ee2

Every methods/variables related to last position. This was used in old onLayout() implementation

Changed data type in all dimensions related fields/methods

1eff270

float to int everywhere except scaleFactor

ResizeTransformer Fix

3fde7a9

Changed implementatnio of position calculation Changed implemenation of getMinWidth() method Fixed sample app (I forgot about that in prev commit)

Cleaned up Transformers code

ca33ccf

Removed unnecesary metods & variables Methods where size is calculated are merged - now in one pas of dragEvent dragView is redrawed only once, not twice

merge conficts

c06b4a6

Fiddl3 added 3 commits December 5, 2014 16:35

downgrade gradle plugin

22decc0

style update

1675159

Unused import removed

e73f2e3

pedrovgs reviewed Dec 5, 2014
View reviewed changes

Updated README & MINIMUM_DX value

673634d

Fiddl3 added 5 commits December 5, 2014 18:56

Fix for secondView issue with ScaleStransformer

96d58cb

Fix for ResiezeTransformer issue

58b63f3

Style update

590f9b5

This should be at end

Small improvements associated with VerticalDrag in ResizeTransformer

b75e8bd

gradle update

d3f77f7

especially for Travis

Fiddl3 added 3 commits December 5, 2014 21:36

Revert "gradle update"

0b5f55e

This reverts commit d3f77f7.

the last approach to the updating

27e35d7

Revert "the last approach to the updating"

43d0a1b

This reverts commit 27e35d7.

pedrovgs added a commit that referenced this pull request Dec 6, 2014

Merge pull request #27 from Fiddl3/ResizeTransformer_fix

d172e50

Resize transformer fix.

pedrovgs merged commit d172e50 into pedrovgs:develop Dec 6, 2014

Fiddl3 deleted the ResizeTransformer_fix branch December 8, 2014 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resize transformer fix #27

Resize transformer fix #27

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

pedrovgs Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 6, 2014

Fiddl3 commented Dec 6, 2014

pedrovgs commented Dec 6, 2014

Fiddl3 commented Dec 6, 2014

pedrovgs commented Dec 6, 2014

Fiddl3 commented Dec 6, 2014

Resize transformer fix #27

Resize transformer fix #27

Conversation

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

pedrovgs Dec 5, 2014

Choose a reason for hiding this comment

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 5, 2014

Fiddl3 commented Dec 5, 2014

pedrovgs commented Dec 6, 2014

Fiddl3 commented Dec 6, 2014

pedrovgs commented Dec 6, 2014

Fiddl3 commented Dec 6, 2014

pedrovgs commented Dec 6, 2014

Fiddl3 commented Dec 6, 2014