Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to specify that node version supported is <9 #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,10 @@ $ npm run dev # or yarn dev
* popup - The page (window) that will be displayed when the icon is clicked
* tab - Your application will work in a separate tab
* ext - Shared scripts
* [manifest.js](https://developer.chrome.com/extensions/manifest) - Descriptions of the application, its rights and possibilities
* [manifest.js](https://developer.chrome.com/extensions/manifest) - Descriptions of the application, its rights and possibilities

## Node Version Supported

* `nvm install` use a node version less than 9 specified in .nvmrc
* `nvm use` use version specified in .nvmrc
* `npm rebuild node-sass` rebuild sass using 8, use before `npm run dev`
1 change: 1 addition & 0 deletions template/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8.16.0
3 changes: 3 additions & 0 deletions template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"author": "[email protected]",
"license": "MIT",
"private": false,
"engines": {
"node": ">=8.0.0 <9.0.0"
},
"dependencies": {
"axios": "^0.17.0",
"element-ui": "^2.0.1",
Expand Down