This repository was archived by the owner on Sep 29, 2024. It is now read-only.
Endianness-agnostic IPv4/UInt32 conversions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap endianness internally.
keeshux
force-pushed
the
endianness-agnostic-dns
branch
from
87cda1c to
9cf9725
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't seem to get endianness right apparently... but this should fix the issue once and for all.
DNSResolvernow takes input and returns output in host endianness, and uses the standard BSD APIinet_pton/inet_ntop.Endianness is crucial because iOS devices are big endian whereas macOS devices are little endian, and this library is meant to be compatible with both.