This repository was archived by the owner on Sep 29, 2024. It is now read-only.
Allow keep-alive timeout to be configured by the server or client #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
reviewed
Oct 21, 2019
| @@ -202,6 +202,9 @@ extension OpenVPN { | |||
| /// Sends periodical keep-alive packets if set. | |||
| public var keepAliveInterval: TimeInterval? | |||
|
|
|||
| /// Disconnects after no keep-alive packets are recieved within timeout interval if set. | |||
|
Yeah, I have tested this live, for configurations with and without the added option. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreConfiguration.OpenVPN.pingTimeout is quite a long timeout for mobile devices, so I've added
KeepAliveTimeout, which can be configured either from the server or usingOpenVPN.Configuration. I have tested both scenarios and added a basic test for ensuring the ping-restart server config is parsed correctly.I'm happy to make changes if there are any issues with my implementation 🙂
Thanks