Maintain one configuration per profile #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
added a commit
that referenced
this pull request
Oct 3, 2024
Follow the same approach as #636, because if no profiles are formerly installed the first import will trigger a VPN permission alert. Weird things may happen in that case if profiles are imported in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with automation. Install the VPN configuration before persisting a profile, so that the 1:1 reference with OS settings is maintained. Likewise, uninstall the VPN configuration after removing a profile.
This before-save hook also resolves a problem with multiple imports, where multiple VPN permission alerts coalesce if no VPN configuration is installed. Now the first import waits for the permission synchronously.
Fixes #618