Stop using the Save Actions plugin (broken in IntelliJ 2023.1) and use native format on save #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
felixdesouza
approved these changes
Apr 6, 2023
|
Released 2.29.0 |
|
This addresses palantir/gradle-baseline#2545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We use the Save Actions IntelliJ plugin but it is broken in IntelliJ 2023.1 and is not maintained and will not have a new release.
After this PR
==COMMIT_MSG==
Stop using the Save Actions plugin (broken in IntelliJ 2023.1) and use native format on save (requires IntelliJ >=2021.2)
==COMMIT_MSG==
In 2021.2, IntelliJ introduced a new built in reformat on save feature. We configure this instead rather than using a custom plugin.
Possible downsides?
The suggesting of Save Actions lives in baseline unfortunately