Bazel build: use Clang and bump rules_foreign and protobuf versions. #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is is preparation for migrating to Bzlmod ( #5066), which requires up-to-date versions of all dependencies. Signed-off-by: Steffen Smolka <[email protected]>
fruffy
approved these changes
Feb 25, 2025
| @@ -3,4 +3,10 @@ common --enable_workspace | |||
| # Enable once #5066 is resolved. | |||
| common --noenable_bzlmod | |||
|
|
|||
| build --action_env=BAZEL_CXXOPTS="-std=c++17" | |||
| # Use C++17. | |||
There was a problem hiding this comment.
This will have the same problem as #4640 where every dependency needs to set those options, right?
fruffy
added
the
infrastructure
Vineet1101
pushed a commit
to Vineet1101/p4c
that referenced
this pull request
Mar 15, 2025
…4lang#5148) Signed-off-by: Steffen Smolka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is is preparation for migrating to Bzlmod ( #5066), which requires up-to-date versions of all dependencies.