Silence some warnings #5125
Merged
Silence some warnings #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asl
commented
Feb 13, 2025
asl
commented
- missed overrides
- lack of virtual distructors in the classes with virtual functions
- mised CTAD guides Also, it seems that .hpp files somehow used old p4c coding style and were not updated. Fix is while there.
- missed overrides - lack of virtual distructors in the classes with virtual functions - mised CTAD guides Also, it seems that .hpp files somehow used old p4c coding style and were not updated. Fix is while there. Signed-off-by: Anton Korobeynikov <[email protected]>
kfcripps
approved these changes
Feb 13, 2025
vlstill
approved these changes
Feb 14, 2025
fruffy
added
the
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.