Clean up clang-format and add a .clangd configuration. #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
infrastructure
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/clang-format-cleanup
branch
from
21b4dcf to
42c3322
Compare
asl
reviewed
Dec 19, 2024
.clang-format
Outdated
| MacroBlockEnd: '' | ||
| MaxEmptyLinesToKeep: 1 | ||
| NamespaceIndentation: None | ||
| ObjCBinPackProtocolList: Never |
There was a problem hiding this comment.
Do we really want all these fine-grained settings? objc-included? Can't we simply specify Google style guide plus all small deviations we're having?
There was a problem hiding this comment.
Works for me. Just need to generate a new file without the GPL header.
Signed-off-by: fruffy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.clang-format had an erroneous GPL header. Regenerate it using
clang-format -style=file -dump-config > .clang-format.Also add a .clangd default configuration which points to the default installation directory
build.