Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Tofino dynamic hash library. #5059

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Clean up Tofino dynamic hash library. #5059

merged 1 commit into from
Dec 17, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Dec 10, 2024 •
edited
Loading

  • Remove the include and src folders. The rest of the compiler doesn't use this structure.
  • Update the cmakelists.txt to use the correct files.

@fruffy fruffy added the tofino Topics related to the Tofino switch and back end. label Dec 10, 2024
@fruffy fruffy force-pushed the fruffy/dyn_hash_fix branch from 2cda1f6 to dabd30d Compare December 11, 2024 14:18
@fruffy fruffy marked this pull request as ready for review December 11, 2024 17:00
@fruffy fruffy requested a review from pkotikal December 11, 2024 17:00
@fruffy fruffy mentioned this pull request Dec 17, 2024
Closed
@fruffy
Copy link
Collaborator Author

fruffy commented Dec 17, 2024

@pkotikal Also fixes some problems with the compiler-local dynhash library.

@fruffy fruffy added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@fruffy fruffy added this pull request to the merge queue Dec 17, 2024
psivanup
psivanup approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@psivanup psivanup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Merged via the queue into main with commit 8a91796 Dec 17, 2024
20 checks passed
@fruffy fruffy deleted the fruffy/dyn_hash_fix branch December 17, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkotikal pkotikal pkotikal approved these changes

@psivanup psivanup psivanup approved these changes

Assignees
No one assigned
Labels
tofino Topics related to the Tofino switch and back end.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruffy @pkotikal @psivanup