Fix modifyAllMatching visitor helper #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
added
the
core
vlstill
commented
Nov 19, 2024
| @@ -820,7 +820,7 @@ const RootType *modifyAllMatching(const RootType *root, Func &&function) { | |||
| Func function; | |||
| void postorder(NodeType *node) override { function(node); } | |||
| }; | |||
| return root->apply(NodeVisitor(std::forward<Func>(function))); | |||
| return root->apply(NodeVisitor(std::forward<Func>(function)))->template checkedTo<RootType>(); | |||
There was a problem hiding this comment.
template keyword needed as the RootType is a type parameter
vlstill
force-pushed
the
vstill/modify-all-matching
branch
from
56ff647 to
b671a45
Compare
Signed-off-by: Vladimír Štill <[email protected]>
ChrisDodd
approved these changes
Nov 19, 2024
Yes. For example a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple fix of
P4::modifyAllMatchingvisitor helper. Basically while theModifiervisitor guarantees that the result type of node transformation is the same as the original, theapplyfunction type cannot reflect that as it has to be able to work with any visitor. Therefore,modifyAllMatchingneeds an explicit cast, otherwise it would work only onRootType = IR::Node.