Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fedora build and fix CMake warnings on versions greater than CMake 3.24. #4986

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Fix Fedora build and fix CMake warnings on versions greater than CMake 3.24. #4986

merged 3 commits into from
Oct 31, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Oct 30, 2024 •
edited
Loading

Also fix some Fedora issues.

  • Use the requirements.txt file in the CI build script instead of custom pip installations.
  • Use the latest version of PTF to fix an issue with deprecated imp and Python >3.12.

@fruffy fruffy added infrastructure Topics related to code style and build and test infrastructure. run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. labels Oct 30, 2024
@fruffy fruffy force-pushed the fruffy/cmake_warnings branch from ceac87d to d7a26b6 Compare October 30, 2024 17:04
@fruffy fruffy force-pushed the fruffy/cmake_warnings branch from d7a26b6 to 667ffbd Compare October 30, 2024 17:20
@fruffy fruffy requested a review from jafingerhut October 31, 2024 02:32
@fruffy fruffy changed the title Fix CMake warnings on versions greater than CMake 3.24. Fix Fedora build and fix CMake warnings on versions greater than CMake 3.24. Oct 31, 2024
jafingerhut
jafingerhut approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut jafingerhut added this pull request to the merge queue Oct 31, 2024
@jafingerhut jafingerhut mentioned this pull request Oct 31, 2024
Closed
Merged via the queue into main with commit 3feffe0 Oct 31, 2024
19 checks passed
@jafingerhut jafingerhut deleted the fruffy/cmake_warnings branch October 31, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure. run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @jafingerhut