Clean up BMv2's run-stf-test script and integrate it with testutils #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/run-stf-test-refactor
branch
2 times, most recently
from
c91fd73 to
816b35a
Compare
fruffy
added
the
infrastructure
fruffy
force-pushed
the
fruffy/run-stf-test-refactor
branch
6 times, most recently
from
1b54e21 to
85f3eea
Compare
fruffy
commented
Oct 25, 2024
| [tool.pylint.main] | ||
| init-hook="from pylint.config import find_default_config_files; import os, sys; sys.path.append(os.path.dirname(next(find_default_config_files())))" | ||
| init-hook="from pylint.config import find_default_config_files; import os, sys, pathlib; sys.path.append(next(find_default_config_files()).parent);sys.path.append(f'{pathlib.Path().home()}.local/lib/python{sys.version_info[0]}.{sys.version_info[1]}/site-packages/');" |
There was a problem hiding this comment.
I noticed the linters were missing some paths. This command adds them. I can make this a separate PR, if needed.
Signed-off-by: fruffy <[email protected]>
Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/run-stf-test-refactor
branch
from
85f3eea to
4d61010
Compare
jafingerhut
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
run-bmv2-test.pyscript in the BMv2 folder. The old script was hard to maintain and didn't use a lot of the tooling we now have available.The new version has types and uses argparse properly. It also calls into the common logging facilities provided by testutils. The script is more compact and simpler to edit now.
@jafingerhut After this refactor, we can also add #4906 on top of it. I will take care of it.