simplifyDefUse: Report the specific uninitialized struct field #4892
Conversation
frontends/p4/simplifyDefUse.cpp
Outdated
| auto fieldLoc = read->getField(field->name); | ||
| auto fieldPoints = currentDefinitions->getPoints(fieldLoc); | ||
| if (fieldPoints->containsBeforeStart()) { | ||
| warn(ErrorType::WARN_UNINITIALIZED_USE, |
There was a problem hiding this comment.
I just realized that the default error reporter will only print 1 warning per use since the node is the same for each loop iteration. Is that OK? The user having to recompile each time they add a definition for a field isn't the best experience.
There was a problem hiding this comment.
That can't be true, as some of the changes in expected stderr traces have mulitple fields noted as being uninitialized.
One concern is that a single large struct with many uninitialized fields could trigger a big spew of warnings -- I considered the idea of first finding the uninitialized fields and then emitting a single message based on that (if just a few fields, could list the fields. Could also detect the corner case when no field is initialized)
ChrisDodd
force-pushed
the
cdodd-uninit-struct-fields
branch
from
c4e3fa7 to
88415de
Compare
Rather than reporting the whole struct, report the specific field(s) that is(are) uninitialized. Signed-off-by: Chris Dodd <[email protected]>
Rather than reporting the whole struct, report the specific field(s) that is(are) uninitialized.