misc fixes/additions

[ChrisDodd]

3 independent changes here

• don't lose annotations on for, and print them properly in dbprint/logging messages
• compute def/use info in functions in midend ComputeDefUse
• use hvec_set instead of ordered_set in midend ComputeDefUse

[asl]

Is is possible to have tests for hvec_set?

[kfcripps]

bazel / build_direct (pull_request) Failing after 5m

@fruffy Is this a real or spurious failure? I see it failing in two other recent PRs too

[asl]

@fruffy Is this a real or spurious failure? I see it failing in two other recent PRs too

Spurious:

WARNING: Download from http://ftpmirror.gnu.org/gnu/make/make-4.3.tar.gz failed: class java.net.ConnectException Connection refused (Connection refused)

[jafingerhut]

When doing wget on this URL, I see there is a redirect to a different URL. Not sure if the way that P4 build process is trying to retrieve this URL, but I believe there are some ways like wget that follow redirects, and some that might not:

$ wget http://ftpmirror.gnu.org/gnu/make/make-4.3.tar.gz
--2024-07-19 12:34:50--  http://ftpmirror.gnu.org/gnu/make/make-4.3.tar.gz
Resolving ftpmirror.gnu.org (ftpmirror.gnu.org)... 2001:470:142:5::200, 209.51.188.200
Connecting to ftpmirror.gnu.org (ftpmirror.gnu.org)|2001:470:142:5::200|:80... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: http://mirror.team-cymru.com/gnu/make/make-4.3.tar.gz [following]
--2024-07-19 12:34:50--  http://mirror.team-cymru.com/gnu/make/make-4.3.tar.gz
Resolving mirror.team-cymru.com (mirror.team-cymru.com)... 2604:8800:50:80:216:31:2:234, 216.31.2.234
Connecting to mirror.team-cymru.com (mirror.team-cymru.com)|2604:8800:50:80:216:31:2:234|:80... failed: Connection refused.
Connecting to mirror.team-cymru.com (mirror.team-cymru.com)|216.31.2.234|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2317073 (2.2M) [application/octet-stream]
Saving to: ‘make-4.3.tar.gz’

make-4.3.tar.gz     100%[===================>]   2.21M  8.96MB/s    in 0.2s    

2024-07-19 12:34:51 (8.96 MB/s) - ‘make-4.3.tar.gz’ saved [2317073/2317073]

[ChrisDodd]

Is is possible to have tests for hvec_set?

added a small gtest

[grg]

LGTM

[asl]

LGTM, just small nit