Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dependabot label generation. #4766

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Simplify dependabot label generation. #4766

merged 1 commit into from
Jun 29, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jun 29, 2024

Dependabot was adding new labels. Stop that.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Jun 29, 2024
@fruffy fruffy force-pushed the fruffy/dependabot_label branch from 4f7ab8f to b4f5d79 Compare June 29, 2024 17:19
jafingerhut
jafingerhut approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rubber stamp review, trusting Fabian knows what he is doing, in case that is all that is needed here. If not, I'd suggest soliciting a more knowledge reviewer to take a look.

@fruffy fruffy added this pull request to the merge queue Jun 29, 2024
@fruffy
Copy link
Collaborator Author

fruffy commented Jun 29, 2024

This is a rubber stamp review, trusting Fabian knows what he is doing, in case that is all that is needed here. If not, I'd suggest soliciting a more knowledge reviewer to take a look.

In any case trivial to undo, this is an attempt to prevent the bots from adding their own labels to PRs.

Merged via the queue into main with commit dfb0106 Jun 29, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/dependabot_label branch June 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @jafingerhut