Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming of CMake Release configuration. #4765

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Fix naming of CMake Release configuration. #4765

merged 1 commit into from
Jun 29, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jun 29, 2024 •
edited
Loading

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Jun 29, 2024
@fruffy fruffy force-pushed the fruffy/fix_release_naming branch from 3555e14 to b8d4791 Compare June 29, 2024 17:20
jafingerhut
jafingerhut approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this is making the name match case-sensitively against occurrences of "Release" in some other part of the CI tooling, this looks good.

@fruffy
Copy link
Collaborator Author

fruffy commented Jun 29, 2024

Assuming that this is making the name match case-sensitively against occurrences of "Release" in some other part of the CI tooling, this looks good.

Indeed, Z3 for example does case-sensitive matching: https://github.com/Z3Prover/z3/blob/master/CMakeLists.txt#L123

@fruffy fruffy added this pull request to the merge queue Jun 29, 2024
Merged via the queue into main with commit b852154 Jun 29, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/fix_release_naming branch June 29, 2024 19:27
@fruffy fruffy mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @jafingerhut