Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to include PHP 8.1 #150

Closed
wants to merge 3 commits into from
Closed

Conversation

phil-davis
Copy link
Contributor

This is a good excuse to run CI and see the results, to investigate issue #149

@phil-davis phil-davis self-assigned this Jun 26, 2022
@phil-davis
Copy link
Contributor Author

Example of a fail: PHP 7.4 with Ubuntu 18.04
https://drone.owncloud.com/owncloud-ci/php/556/13/2

Step 13/19 : RUN ln -s /usr/include/oracle/12.2/client64 /usr/lib/oracle/12.2/client64/include &&   echo "instantclient,/usr/lib/oracle/12.2/client64/lib" | pecl install oci8-2.2.0
 ---> Running in a81386bc1366
Warning: foreach() argument must be of type array|object, null given in Command.php on line 249
...

@phil-davis
Copy link
Contributor Author

PHP 7.4 with Ubuntu 20.04 also fails in the same way.

PHP 7,4 with Ubuntu 22.04 passes: https://drone.owncloud.com/owncloud-ci/php/556/17/2

Step 13/19 : RUN ln -s /usr/include/oracle/12.2/client64 /usr/lib/oracle/12.2/client64/include &&   echo "instantclient,/usr/lib/oracle/12.2/client64/lib" | pecl install oci8-2.2.0
 ---> Running in ec1f515d80b4
WARNING: channel "pecl.php.net" has updated its protocols, use "pecl channel-update pecl.php.net" to update
downloading oci8-2.2.0.tgz ...
Starting to download oci8-2.2.0.tgz (196,449 bytes)
.........................................done: 196,449 bytes
11 source files, building
...

@phil-davis
Copy link
Contributor Author

919852a
I only changed the docker plugins version for a single PHP 7.4 pipeline, but the whole CI suddenly passes.
What is going on? I was expecting other pipelines that failed in https://drone.owncloud.com/owncloud-ci/php/556 to still be failing.

@phil-davis
Copy link
Contributor Author

@xoxys various CI pipelines failed yesterday - see the first commit and the associated drone CI results.

I have been trying to work out what was wrong. But now I have added the 2nd commit to "hack" stuff, and lots of pipelines passed.

I reverted that 2nd commit just now - see the 3rd commit. CI has passed.

Am I going crazy? Or is there a reason that a bunch of PHP 7.* with Ubuntu 18.04 pipelines failed yesterday? (or both!)

@xoxys
Copy link
Contributor

xoxys commented Jun 27, 2022

Im confused. How is the drone docker plugin?

@phil-davis
Copy link
Contributor Author

Im confused. How is the drone docker plugin?

I am also confused.
https://github.com/owncloud-ci/php/blob/master/.drone.star#L197
'image': 'plugins/docker'

That was unchanged, and that step was failing yesterday, Sunday, in the PHP 7.* with Ubuntu 18.04 and 20.04 pipelines. PHP 5.6 passed, PHP 7.4 with Ubuntu 22.04 passed, PHP 8.0 and 8.1 passed.

So I tried the hack in the 2nd commit - for the PHP 7.4 with Ubuntu 18.04 pipeline I chose plugins/docker:20.12 - 20.13 was published 19 days ago, so looked maybe like it was released the day after the previous successful build 20 days ago. That passed - but I expected to only get 1 extra pipeline passing - I only changed the CI for one pipeline.

So I reverted that commit, and now it all passed - why???

I thought that maybe you would tell me about something that happened to thr drone/docker environment at the weekend that has been corrected today.

Maybe we will never know why it failed yesterday (Sunday)

@phil-davis
Copy link
Contributor Author

Hmmm - just did sudo apt update on my local Ubuntu 20.04 system and there were a whole lot of ondrej PHP updates again. There had been a set of them some time over the weekend that I applied, and those got me to the last PHP patch level - for example, PHP 7.4.30.

The ones that updated just now still show PHP 7.4.30 but with today's date. So they were all rebuilt somewhere today. Maybe Ondrej did something - rebuilt all the releases for some reason.

@phil-davis
Copy link
Contributor Author

See #151 for a clean CI run with a single commit.

@phil-davis phil-davis closed this Jun 27, 2022
@xoxys
Copy link
Contributor

xoxys commented Jun 27, 2022

I thought that maybe you would tell me about something that happened to thr drone/docker environment at the weekend that has been corrected today.

I have no idea to be honest.

@phil-davis phil-davis deleted the update-readme-20220626 branch June 28, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants