feat: Improve error messages #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3st3ry
requested review from
loopfz,
pablito-perez and
rbeuque74
as code owners
|
Just a suggestion but it would be nice for your APIs to use the |
w3st3ry
added
🚧 WIP 🚧
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
Signed-off-by: Valentin Pichard <[email protected]>
w3st3ry
force-pushed
the
improve-error-msgs
branch
from
02f1627 to
881dab0
Compare
Signed-off-by: Valentin Pichard <[email protected]>
|
@geoffreybauduin at this team we still compiling with go1.12. We gonna do this change in the future. |
rbeuque74
reviewed
Feb 27, 2020
rbeuque74
added a commit
that referenced
this pull request
Feb 27, 2020
Signed-off-by: Romain Beuque <[email protected]>
rbeuque74
added a commit
that referenced
this pull request
Mar 3, 2020
…d by #51) NotifyBackends can be empty ( as https://github.com/ovh/utask/blob/master/pkg/notify/notify.go#L51 )
rbeuque74
added a commit
that referenced
this pull request
Mar 3, 2020
…d by #51) NotifyBackends can be empty ( as https://github.com/ovh/utask/blob/master/pkg/notify/notify.go#L51 ) Signed-off-by: Romain Beuque <[email protected]>
rbeuque74
added a commit
that referenced
this pull request
Mar 3, 2020
…d by #51) NotifyBackends can be empty ( as https://github.com/ovh/utask/blob/master/pkg/notify/notify.go#L51 ) Signed-off-by: Romain Beuque <[email protected]>
rbeuque74
added a commit
that referenced
this pull request
Mar 3, 2020
…d by #51) NotifyBackends can be empty ( as https://github.com/ovh/utask/blob/master/pkg/notify/notify.go#L51 ) Signed-off-by: Romain Beuque <[email protected]>
rbeuque74
added a commit
that referenced
this pull request
Mar 3, 2020
…d by #51) (#83) NotifyBackends can be empty ( as https://github.com/ovh/utask/blob/master/pkg/notify/notify.go#L51 ) Signed-off-by: Romain Beuque <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #42
Signed-off-by: Valentin Pichard [email protected]