Feat/nutanix scale in out improvements #16072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibault Barske <[email protected]>
tibs245
requested review from
pauldkn,
darsene and
sefiani-ovh
and removed request for
a team
pauldkn
approved these changes
Mar 19, 2025
sefiani-ovh
reviewed
Mar 19, 2025
| .then((node) => { | ||
| this.mapPossibleActions(node.possibleActions); | ||
| }) | ||
| .catch(() => { |
There was a problem hiding this comment.
Not blocking but maybe its better
this.mapPossibleActions(node?.possibleActions || []))
BETA api (no trust :) )
There was a problem hiding this comment.
It's the contract with API. This informations should be alway exists
| this.possibleActionsMapped[action] = { isPossible, reason }; | ||
| }); | ||
|
|
||
| if (this.hasOnlyMinimumNode) { | ||
| this.possibleActionsMapped[POSSIBLE_ACTIONS.TERMINATE].isPossible = false; |
There was a problem hiding this comment.
Not safe at all , check if his.possibleActionsMapped[POSSIBLE_ACTIONS.TERMINATE] is defined
There was a problem hiding this comment.
It's the contract with API. This informations should be alway exists
Signed-off-by: Thibault Barske <[email protected]>
tibs245
force-pushed
the
feat/nutanix-scale-in-out-improvements
branch
from
eebebc1 to
031efc4
Compare
sefiani-ovh
approved these changes
Mar 25, 2025
Signed-off-by: Thibault Barske <[email protected]>
tibs245
force-pushed
the
feat/nutanix-scale-in-out-improvements
branch
from
031efc4 to
3954d07
Compare
tibs245
requested review from
qpavy,
chipp972 and
sachinrameshn
and removed request for
a team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #...
Additional Information