-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Launch command suite in the new CLI #612
Conversation
Besides changing I assume there'll be documentation checked in at some point? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ease of review, is there any significant difference in logic between this PR and oumi/src/oumi/launch.py
?
You're correct, the main change is how additional params are passed. At some point (soon) we'll update this documentation. For now, here's a concrete example using What we have now:
After my changes:
|
Nope, it's almost entirely the same. The only minor shift is from using a threadpool -> a process pool for polling jobs. |
Example commands:
oumi launch status
oumi launch which
oumi launch up --config foo
oumi launch run --config foo
oumi launch down --cluster a --cloud b
oumi launch stop --cluster a --cloud b --id c
Towards OPE-500 and OPE-473