Set up a new version of the Oumi CLI using Typer #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikg4
reviewed
Oct 5, 2024
src/oumi/core/cli/train.py
Outdated
| import typer | ||
| from typing_extensions import Annotated | ||
|
|
||
| import oumi.core.cli.utils as utils |
There was a problem hiding this comment.
Can we use a more specific name like as cli_utils ? utils is too generic
There was a problem hiding this comment.
Sure, renamed to cli_utils.
nikg4
approved these changes
Oct 5, 2024
|
Would users still be able to run |
They can still run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
oumicommand that accepts 3 subcommands:oumi trainoumi inferoumi evaluateThese commands have full typer integration.
I will be adding
oumi launchas a follow-up as it's more involved.I will remove the old CLI when we have parity + update all references.
Towards OPE-500 and OPE-473