Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProfilerParams docstrings to follow the new style #583

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

nikg4
Copy link
Collaborator

@nikg4 nikg4 commented Oct 4, 2024

-- To simplify, and, for consistency, with all other params

Fixes OPE-136

@nikg4 nikg4 requested review from oelachqar, taenin, wizeng23 and a team October 4, 2024 17:18
@nikg4 nikg4 changed the title Update ProfilerParams docstrings to follow the style Update ProfilerParams docstrings to follow the new style Oct 4, 2024
Copy link

linear bot commented Oct 4, 2024

OPE-136

Copy link
Collaborator

@taenin taenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nikolai!

@nikg4 nikg4 merged commit dfb366d into main Oct 4, 2024
1 check passed
@nikg4 nikg4 deleted the xrdaukar/profiler-docstrings branch October 4, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants