Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Evaluation] Save Utils: Moving, fixes, and unit tests #1506

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

kaisopos
Copy link
Contributor

@kaisopos kaisopos commented Mar 4, 2025

Description

Evaluation | Save Utils

  • Moving 2 evaluation util files from oumi/evaluation to oumi/core/evaluation/utils, since all the evaluation-related code has been moved there.
  • Fixing an issue in save_utils occurring when overwriting a pre-existing dir.
  • Adding unit tests for save_utils.

Related issues

Towards OPE-1097

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@kaisopos kaisopos requested review from taenin and wizeng23 March 4, 2025 02:25
@kaisopos kaisopos merged commit e31dd22 into main Mar 4, 2025
2 checks passed
@kaisopos kaisopos deleted the kostas/evaluation_save_utils_improvements branch March 4, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants