Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oumi infer to fall back to interactive mode if no input path is specified. #1483

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

taenin
Copy link
Collaborator

@taenin taenin commented Feb 26, 2025

Description

This is a Quality of Life change for the CLI. If the user doesn't specify interactive inference AND doesn't specify an input path, we'll default to interactive inference.

Additionally, we'll always prevent interactive inference if the user specifies an input file. This is in preparation for removing this flag. We should instead use the presence of the input_file as an indicator for whether or not we run interactive inference.

Related issues

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@taenin taenin marked this pull request as ready for review February 26, 2025 00:28
@taenin taenin merged commit c9b9ea1 into main Feb 26, 2025
2 checks passed
@taenin taenin deleted the taenin/default_infer branch February 26, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants